Posts by emmet

emmet · Is an "OR" query condition possible? emmet October 22, 2021 at 2:20 PM

Hi Marcel,

Thanks a mill for that. I ended up with exactly as you said, I'll put the scripts below for anyone else in a similar situation.

Here is WorkListQueryConverter0:

Code

-- Always filter by the calling AETitle
Data["0040,0001"] = Association.Calling;

-- Remove some filters that some modalities ask for, which cause problems
Data.RequestedProcedureID = nil;
if Data.ScheduledProcedureStepSequence then
  Data.ScheduledProcedureStepSequence[0].ScheduledProcedureStepLocation = nil;
  Data.ScheduledProcedureStepSequence[0].ScheduledStationName = nil
end

-- Next we overwrite the date/time of the results, we filter further in WorkListQueryResultConverter0
-- Note that we can't filter by time here, only date, since we can't use OR in the query we
-- can only filter out by dates outside the desired window in WorkListQueryResultConverter0
-- https://forum.image-systems.biz/forum/index.php?thread/50405-is-an-or-query-condition-possible/

startTimestamp = os.time(os.date('*t')) - (60 * 60 * 12)
endTimestamp = os.time(os.date('*t')) + (60 * 60 * 12)

startDate = os.date("%Y%m%d", startTimestamp)
endDate = os.date("%Y%m%d", endTimestamp)

startTime = os.date("%H%M%S", startTimestamp)

Data.ScheduledProcedureStepStartDate = startDate .. "-" .. endDate

-- This is here just to ensure the time is returned in the response, it doesnt exclude anything
Data.ScheduledProcedureStepStartTime = '000000-235959'

Display More

And here is ModalityWorklistQueryResultConverter0:

Code

startTimestamp = os.time(os.date('*t')) - (60 * 60 * 12)
endTimestamp = os.time(os.date('*t')) + (60 * 60 * 12)

startDate = os.date("%Y%m%d", startTimestamp)
endDate = os.date("%Y%m%d", endTimestamp)

startTime = os.date("%H%M%S", startTimestamp)
endTime = os.date("%H%M%S", endTimestamp)

-- Remove any result that is outside our window
if (Data.ScheduledProcedureStepStartDate and Data.ScheduledProcedureStepStartTime and Data.ScheduledProcedureStepStartDate <= startDate and Data.ScheduledProcedureStepStartTime < startTime) then
    print("Skipping worklist result " .. Data.ScheduledProcedureStepStartDate .. " at " .. Data.ScheduledProcedureStepStartTime .. " because it's outside window of ".. startDate .. " " .. startTime .. " to " .. endDate .. " " .. endTime)
    destroy()
end

if (Data.ScheduledProcedureStepStartDate and Data.ScheduledProcedureStepStartTime and Data.ScheduledProcedureStepStartDate >= endDate and Data.ScheduledProcedureStepStartTime > endTime) then
    print("Skipping worklist result " .. Data.ScheduledProcedureStepStartDate .. " at " .. Data.ScheduledProcedureStepStartTime .. " because it's outside window of ".. startDate .. " " .. startTime .. " to " .. endDate .. " " .. endTime)
    destroy()
end

print("Keeping worklist result " .. Data.ScheduledProcedureStepStartDate .. " at " .. Data.ScheduledProcedureStepStartTime .. " because it's within window of ".. startDate .. " " .. startTime .. " to " .. endDate .. " " .. endTime)

Display More

I'm more than happy to hear any improvements to these, so far it looks like it will do the trick quite nicely.

Thanks again marcelvanherk !

emmet · Is an "OR" query condition possible? emmet October 20, 2021 at 6:57 PM

We have modalities that are configured to query conquest by today's date by default, and some modalities allow users to change this when querying but some don't. For those that don't it creates a situation around midnight each night where things get a little unpredictable and very time dependant, for example if a scan is scheduled for 00:10 the following day but it's only 23:50 at the moment then the operator has to wait until midnight to see the entry. Things also become very sensitive to how correct the clocks are on each modality and on conquest, and a difference of a few minutes or more will cause similar mismatching effects. To further complicate things, some modalities implement a feature where they can search for studies "within X hours of now" but in practice it's not always implemented correctly and if this window of time crosses over into a different day it results in a query to conquest like "date>=today AND time>=21:00 AND date<=tomorrow AND time<= 03:00". When this happens this query returns no results, because of the way the times are ANDed (eg >=21:00 AND <= 03:00).

To avoid these issues I'm exploring the possibility of using a WorkListQueryConverter0 to override all date and time queries that a modality may have set, and instead set it to a rolling window that I can apply to all incoming queries, for example filter to all studies from 24 hours in the past to 24 hours in the future no matter what time/date was queried for. However to do this without falling into the wierdness around midnight mentioned above I need an OR clause, for example "(date >=today AND time>=21:00) OR (date<=tomorrow AND time<= 03:00)".

I've tried searching in the code to see if it's possible to do an OR instead of an AND when setting fields in the query but I don't think I found the right place. I've also tried searching to see if it's even possible to define an OR in these queries but also couldn't find any guidance from the standard.

Is this possible? Any suggestions or pointers would be greatly appreciated, thanks in advance!

emmet

Ah, I didn't know about that, that's great, thank you!

emmet

Hi Marcel!

That worked, thank you!

My next step will be to move this into a lua script instead of inline in dicom.ini so that I can loop over all children in the node, as at the moment this will only ignore the first in the sequence ([0]), but won't ignore a second or third element in the request. Ad edge case but worth covering.

However I'm still a little unsure how to figure out what the name of the keys are in lua, especially when it's a nested. To illustrate with "0040,0001" as an example.

Knowing that the tag is 0040,0001 I can look it up and find something like this, which tells me that this key is nested within Scheduled Procedure Step Sequence (nested meaning I'll have to index it using "[0]" or else loop over it) and is called Scheduled Station AE Title. However the name is with spaces here, so should I guess that the name in conquest will be the same as there but without spaces, "ScheduledProcedureStepSequence" and "ScheduledStationAETitle" in this case? Is that the right approach? Or do you recommend any other documentation to look these up or debug the actual contents of a Data object?

Thanks again!

emmet

Here's a log when the query comes in:

Code

UPACS THREAD 221: STARTED AT: Sun Oct 17 13:25:34 2021
A-ASSOCIATE-RQ Packet Dump
    Calling Application Title : "MY_AET "
    Called Application Title : "MY_MWL "
    Application Context : "1.2.840.10008.3.1.1.1", PDU length: 16384
    Number of Proposed Presentation Contexts: 1
    Presentation Context 0 "1.2.840.10008.5.1.4.31" 1
Server Command   := 0020
Message ID       := 0001
0000,0002     22 UI AffectedSOPClassUID    "1.2.840.10008.5.1.4.31" 
0000,0100      2 US CommandField           32 
0000,0110      2 US MessageID              1 
0000,0700      2 US Priority               0 
0000,0800      2 US DataSetType            258 
0002,0010     17 UI TransferSyntaxUID      "1.2.840.10008.1.2" 
(ModalityWorkListQuery) search level: 
0002,0010     17 UI TransferSyntaxUID      "1.2.840.10008.1.2" 
0008,0050      0 SH AccessionNumber        (empty)
0008,0090      0 PN ReferringPhysicianNa   (empty)
0008,1110      0 SQ ReferencedStudySeque   Sequence Item
>0008,1150      0 UI ReferencedSOPClassUI   (empty)
>0008,1155      0 UI ReferencedSOPInstanc   (empty)
0010,0010      0 PN PatientName            (empty)
0010,0020      0 LO PatientID              (empty)
0010,0030      0 DA PatientBirthDate       (empty)
0010,0040      0 CS PatientSex             (empty)
0010,1010      0 AS PatientAge             (empty)
0010,1020      0 DS PatientSize            (empty)
0010,1030      0 DS PatientWeight          (empty)
0010,2000      0 LO MedicalAlerts          (empty)
0010,2110      0 LO Allergies              (empty)
0010,21c0      0 US PregnancyStatus        (empty)
0020,000d      0 UI StudyInstanceUID       (empty)
0032,1032      0 PN RequestingPhysician    (empty)
0032,1033      0 LO RequestingService      (empty)
0032,1060      0 LO RequestedProcedureDe   (empty)
0038,0400      0 LO PatientInstitutionRe   (empty)
0040,0001     14 AE ScheduledStationAETi   "MY_AET " 
0040,0100      0 SQ ScheduledProcedureSt   Sequence Item
>0008,0060      2 CS Modality               "CR" 
>0032,1070      0 LO RequestedContrastAge   (empty)
>0040,0001     14 AE ScheduledStationAETi   "MY_AET " 
>0040,0002      8 DA ScheduledProcedureSt   "20211017" 
>0040,0003      0 TM ScheduledProcedureSt   (empty)
>0040,0006      0 PN ScheduledPerformingP   (empty)
>0040,0007      0 LO ScheduledProcedureSt   (empty)
>0040,0008      0 SQ ScheduledProtocolCod   Sequence Item
>>0008,0100      0 SH CodeValue              (empty)
>>0008,0102      0 SH CodingSchemeDesignat   (empty)
>>0008,0103      0 SH CodingSchemeVersion    (empty)
>>0008,0104      0 LO CodeMeaning            (empty)
>0040,0009      0 SH ScheduledProcedureSt   (empty)
>0040,0010     14 SH ScheduledStationName   "MY_AET " 
>0040,0011     22 SH ScheduledProcedureSt   "my clinic" 
>0040,0012      0 LO PreMedication          (empty)
0040,1002      0 LO ReasonForTheRequeste   (empty)
Query On Modality WorkList
Queried item 0008 0090 is not in the database
Queried item 0008 1150 is not in the database
Queried item 0008 1155 is not in the database
Queried item 0010 1010 is not in the database
Queried item 0010 1020 is not in the database
Queried item 0010 1030 is not in the database
Queried item 0010 21c0 is not in the database
Queried item 0032 1033 is not in the database
Queried item 0038 0400 is not in the database
Queried item 0008 0100 is not in the database
Queried item 0008 0102 is not in the database
Queried item 0008 0103 is not in the database
Queried item 0008 0104 is not in the database
Queried item 0040 1002 is not in the database
Issue Query on Columns: DICOMWorkList.AccessionN, DICOMWorkList.PatientNam, DICOMWorkList.PatientID, DICOMWorkList.PatientBir, DICOMWorkList.PatientSex, DICOMWorkList.MedicalAle, DICOMWorkList.ContrastAl, DICOMWorkList.StudyInsta, DICOMWorkList.ReqPhysici, DICOMWorkList.ReqProcDes, DICOMWorkList.ScheduledA, DICOMWorkList.Modality, DICOMWorkList.ReqContras, DICOMWorkList.ScheduledA, DICOMWorkList.StartDate, DICOMWorkList.StartTime, DICOMWorkList.PerfPhysic, DICOMWorkList.SchedPSDes, DICOMWorkList.SchedPSID, DICOMWorkList.SchedStati, DICOMWorkList.SchedPSLoc, DICOMWorkList.PreMedicat
Values: DICOMWorkList.ScheduledA = E'MY_AET' and DICOMWorkList.Modality = E'CR' and DICOMWorkList.ScheduledA = E'MY_AET' and DICOMWorkList.StartDate = E'20211017' and DICOMWorkList.SchedStati = E'MY_AET' and DICOMWorkList.SchedPSLoc = E'my clinic'
Tables: DICOMWorkList
Sorting (DICOMWorkList.PatientNam) DoSort := 1
Query Distinct Tables: DICOMWorkList
Columns              : DICOMWorkList.AccessionN, DICOMWorkList.PatientNam, DICOMWorkList.PatientID, DICOMWorkList.PatientBir, DICOMWorkList.PatientSex, DICOMWorkList.MedicalAle, DICOMWorkList.ContrastAl, DICOMWorkList.StudyInsta, DICOMWorkList.ReqPhysici, DICOMWorkList.ReqProcDes, DICOMWorkList.ScheduledA, DICOMWorkList.Modality, DICOMWorkList.ReqContras, DICOMWorkList.ScheduledA, DICOMWorkList.StartDate, DICOMWorkList.StartTime, DICOMWorkList.PerfPhysic, DICOMWorkList.SchedPSDes, DICOMWorkList.SchedPSID, DICOMWorkList.SchedStati, DICOMWorkList.SchedPSLoc, DICOMWorkList.PreMedicat
Where                : DICOMWorkList.ScheduledA = E'MY_AET' and DICOMWorkList.Modality = E'CR' and DICOMWorkList.ScheduledA = E'MY_AET' and DICOMWorkList.StartDate = E'20211017' and DICOMWorkList.SchedStati = E'MY_AET' and DICOMWorkList.SchedPSLoc = E'my clinic'
Order                : DICOMWorkList.PatientNam
Records = 0
C-Find (Modality Work List) located 0 records
Arena 0:
system bytes     =    1241088
in use bytes     =     976800
Arena 1:
system bytes     =    1003520
in use bytes     =       2240
Arena 2:
system bytes     =    1024000
in use bytes     =     446192
Total (incl. mmap):
system bytes     =    3403776
in use bytes     =    1560400
max mmap regions =          2
max mmap bytes   =     446464
UPACS THREAD 221: ENDED AT: Sun Oct 17 13:25:34 2021
UPACS THREAD 221: TOTAL RUNNING TIME: 0 SECONDS
Connected by address: 804aa8c0
Testing transfer: '1.2.840.10008.1.2.1' against list #0 = '1.2.840.10008.1.2'
Testing transfer: '1.2.840.10008.1.2.1' against list #1 = '1.2.840.10008.1.2.1'
Arena 0:
system bytes     =    1241088
in use bytes     =     976800
Arena 1:
system bytes     =    1003520
in use bytes     =       2240
Arena 2:
system bytes     =    1024000
in use bytes     =     424960
Total (incl. mmap):
system bytes     =    3403776
in use bytes     =    1539168
max mmap regions =          2
max mmap bytes   =     446464

Display More

I'm aiming to ignore (delete from the query) the DICOMWorkList.SchedPSLoc and DICOMWorkList.SchedStati fields before conquest checks it's database.

emmet

marcelvanherk if you have any pointers or clues it would be great, thanks!

emmet

I've also found this, it has examples for some sequences (which gave me inspiration to try the post above) but still no dice:

https://github.com/spectra/conque…ua/overview.lua

emmet

Something else I've tried:

Code

[lua]
# Add a filter of the calling AETitle to all incoming queries, also remove DICOMWorkList.SchedPSLoc
QueryConverter0 = Data["0040,0001"] = Association.Calling; Data.ScheduledProcedureStepSequence[0].ScheduledProcedureStepLocation = nil; Data.ScheduledProcedureStepSequence[0].ScheduledStationName = nil
RetrieveConverter0 = Data["0040,0001"] = Association.Calling; Data.ScheduledProcedureStepSequence[0].ScheduledProcedureStepLocation = nil; Data.ScheduledProcedureStepSequence[0].ScheduledStationName = nil
WorkListQueryConverter0 = Data["0040,0001"] = Association.Calling; Data.ScheduledProcedureStepSequence[0].ScheduledProcedureStepLocation = nil; Data.ScheduledProcedureStepSequence[0].ScheduledStationName = nil

But this results in an error:

Code

*** lua run error [string "Data["0040,0001"] = Association.Calling; Da..."]:1: attempt to index field 'ScheduledProcedureStepSequence' (a nil value) in 'Data["0040,0001"] = Association.Calling; Data.ScheduledProcedureStepSequence[0].ScheduledProcedureStepLocation = nil; Data.ScheduledProcedureStepSequence[0].ScheduledStationName = nil'

emmet

Hi,

I'm looking to delete some very specific dicom tags from the mwl queries that come in from the modalities. I'm hoping to do this on conquest in order to avoid having to reconfigure lots of modalities. However I'm having problems figuring out how to set some nested fields to nil (delete them).

The fields I want to delete are:

0040,0011
0040,1001
0040,0010

Here's what I've tried in dicom.ini:

Code

# Add a filter of the calling AETitle to all incoming queries, also remove DICOMWorkList.SchedPSLoc
QueryConverter0 = Data["0040,0001"] = Association.Calling; Data["0040,0011"] = nil; Data["0040,1001"] = nil; Data["0040,0010"] = nil
RetrieveConverter0 = Data["0040,0001"] = Association.Calling; Data["0040,0011"] = nil; Data["0040,1001"] = nil; Data["0040,0010"] = nil
workListQueryConverter0 = Data["0040,0001"] = Association.Calling; Data["0040,0011"] = nil; Data["0040,1001"] = nil; Data["0040,0010"] = nil

The first bit is to add a new filter for the Scheduled Station AE Title by AETitle, this is working fine. However the other bits don't, I suspect it's because these are nested but I can't figure out the syntax for nested dicom tags.

I've found info here and found some examples on this forum on how to set the data but couldn't find an example using the fields I want to manipulate.

Any suggestions or pointers would be very welcome, thanks in advance!

Posts by emmet

Is an "OR" query condition possible?

Is an "OR" query condition possible?

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0

Manipulating (deleting) nested dicom tags in WorkListQueryConverter0